Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added taxonomies LinkedTitle #2046

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added taxonomies LinkedTitle #2046

wants to merge 1 commit into from

Conversation

TonyWu1995
Copy link

issue #2045

Before:

image

After:

image

image

fekete-robert
fekete-robert approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@fekete-robert fekete-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

huanlin
huanlin reviewed Jul 30, 2024
View reviewed changes
Copy link
Contributor

@huanlin huanlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

deining
deining approved these changes Jul 30, 2024
View reviewed changes
Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chalin chalin added this to the 24Q3 milestone Aug 5, 2024
@chalin chalin added the enhancement New feature or request label Aug 5, 2024
chalin
chalin reviewed Aug 5, 2024
View reviewed changes
Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fekete-robert @deining @TonyWu1995 - won't this break if there is no .LinkTitle? Have you tested this scenario?

@TonyWu1995
Copy link
Author

@fekete-robert @deining @TonyWu1995 - won't this break if there is no .LinkTitle? Have you tested this scenario?

The LinkTitle method returns the linkTitle field as defined in front matter, falling back to the value returned by the Title method. --from: LinkTitle

If there is no linktitle, the tag will be like this:

image

because the frontmatter is defined like this:

---
title: Artificial Intelligence
---

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huanlin huanlin huanlin left review comments

@chalin chalin chalin left review comments

@fekete-robert fekete-robert fekete-robert approved these changes

@deining deining deining approved these changes

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
24Q3
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@TonyWu1995 @huanlin @fekete-robert @chalin @deining